[PATCH] D123484: [WebAssembly] Implement ref.is_null MC layer support and codegen

[Thomas Lively via Phabricator via llvm-commits]

tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

LGTM! (with single comment)



================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:312
+  } else if (Name == "ref.is_null") {
+    // FIXME: overly permissive - accepts any value.
+    if (popType(ErrorLoc, {}))
----------------
How complicated would this be to fix? Is it worth fixing now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123484/new/

https://reviews.llvm.org/D123484