[PATCH] D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment



================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:1231
+// Modeled after X86TargetLowering::markLibCallAttributes.
+static void markLibCallAttributes(Function *F) {
+  if (!F->arg_size() || F->isVarArg())
----------------
This could probably use a better name to indicate what it's doing.  Maybe markRegisterParameterAttributes()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125285/new/

https://reviews.llvm.org/D125285