[PATCH] D125285: [BuildLibCalls] infer inreg param attrs from NumRegisterParameters

Tue May 10 15:41:17 PDT 2022

nickdesaulniers added a comment.

In D125285#3504802 <https://reviews.llvm.org/D125285#3504802>, @efriedma wrote:

> In D125285#3504537 <https://reviews.llvm.org/D125285#3504537>, @nickdesaulniers wrote:
>
>> In D125285#3504529 <https://reviews.llvm.org/D125285#3504529>, @efriedma wrote:
>>
>>> I can't find any libcalls with i64 arguments we emit in IR (on 32-bit targets).
>>
>> Should I drop the `getTypeAllocSize` related check for now, if we can't provide test coverage? (I guess I could write a unittest, but plz no).
>
> I guess you could replace it with an assertion?  I think I'm fine leaving it without an explicit testcase, though.

I've left the logic, but added the assertion. Please let me know if you'd prefer that I simplified the logic based on the assertion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125285/new/

https://reviews.llvm.org/D125285