[PATCH] D125158: [DirectX backend] Add pass to emit dxil metadata.

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.

LGTM.



================
Comment at: llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp:63
+
+namespace {
+class DXILTranslateMetadata : public ModulePass {
----------------
kuhar wrote:
> You can open this namespace higher up so that you don't need to annotate each function with static
not to nitpick, but that comment contradicts the coding standards, and is the opposite of the feedback I provided :)

see: https://www.llvm.org/docs/CodingStandards.html#anonymous-namespaces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125158/new/

https://reviews.llvm.org/D125158