[PATCH] D125158: [DirectX backend] Add pass to emit dxil metadata.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 10:25:19 PDT 2022


kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

LGTM but please get another one before submitting.



================
Comment at: llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp:63
+
+namespace {
+class DXILTranslateMetadata : public ModulePass {
----------------
You can open this namespace higher up so that you don't need to annotate each function with static


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125158/new/

https://reviews.llvm.org/D125158



More information about the llvm-commits mailing list