[PATCH] D125000: [RS4GC] Cache BaseDefiningValueResult instead of BDV (NFC)

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added a comment.

General questions: there are multiple places where we call `eraseFromParent`. Is there a guarantee that after this the cache is valid? Any way to verify this?



================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:294
+                      const BaseDefiningValueResult &RHS) {
+    // dbgs() << "LHS BDV = " << LHS.getBDV() << ", RHS BDV = " << RHS.getBDV() << "LHS IsKnownBase = " << LHS.isKnownBase() << ", RHS IsKnownBase = " << RHS.isKnownBase() << "\n";
+    return LHS.getBDV() == RHS.getBDV() &&
----------------
Remove?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125000/new/

https://reviews.llvm.org/D125000