[PATCH] D125003: [RS4GC] Treat a value that has a single base and no derived inputs as base value
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 10 01:41:31 PDT 2022
mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.
LGTM w/ nit.
================
Comment at: llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:847
AssertingVH<Value> BaseValue = nullptr; // Non-null only if Status == Base.
+ bool IsDerived = true;
};
----------------
I think a clarifying comment is needed here. Does `IsDerived = true` mean that it must be a derived pointer, or does it simply mean that we haven't proven it's a base?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125003/new/
https://reviews.llvm.org/D125003
More information about the llvm-commits
mailing list