[PATCH] D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

[Wenlei He via Phabricator via llvm-commits]

wenlei added a comment.

In D125255#3502490 <https://reviews.llvm.org/D125255#3502490>, @wlei wrote:

> In D125255#3502398 <https://reviews.llvm.org/D125255#3502398>, @wenlei wrote:
>
>>> add a parameter to emitWarningSummary to customize value for critical warning, default value increase to 20%.
>>
>> Do we even need a threshold for emitting critical ones? If it's critical, we should always emit them?
>
> Sorry for the confusing, " customize value for critical warning" is wrong, I meant the parameter is used to treat warnings of different importance differently. For critical warning, the threshold is 0, then it's always emitted. For non-critical ones, developer can still set a threshold or use the default one, then emit it if it's above it.

Ok, maybe a verbose mode is enough for enabling all warnings. I can see that a threshold for non-critical warnings could be potentially useful, but also wondering if we could just keep things very simple here. The goal is not to give user a lot of control on what to print out, but to make sure 1) the default warning printing is meaningful to average users, 2) advanced users have a way to print everything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125255/new/

https://reviews.llvm.org/D125255