[PATCH] D125255: [llvm-profgen] Support a threshold to control hiding warning summaries

[Lei Wang via Phabricator via llvm-commits]

wlei added a comment.

In D125255#3502398 <https://reviews.llvm.org/D125255#3502398>, @wenlei wrote:

>> add a parameter to emitWarningSummary to customize value for critical warning, default value increase to 20%.
>
> Do we even need a threshold for emitting critical ones? If it's critical, we should always emit them?

Sorry for the confusing, " customize value for critical warning" is wrong, I meant the parameter is used to treat warnings of different importance differently. For critical warning, the threshold is 0, then it's always emitted. For non-critical ones, developer can still set a threshold or use the default one, then emit it if it's above it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125255/new/

https://reviews.llvm.org/D125255