[PATCH] D125133: [riscv] Fix state tracking bug on vsetvli (phi of vsetvli) peephole

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM but yeah I prefer @gkm's suggestion.



================
Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:1128
+        if (needVSETVLI(NewInfo, BlockInfo[MBB.getNumber()].Pred)) {
+          // IF this is the first implicit state change, and the state change
+          // requested can be proven to produce the same register contents, we
----------------
reames wrote:
> gkm wrote:
> > Nit-picky code structure suggestion ...
> Good point.  Will refresh on Monday.
Just to double-check whether this `IF` is intentionally all-caps?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125133/new/

https://reviews.llvm.org/D125133