[PATCH] D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 02:10:04 PDT 2022


pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/float-strict-powi-convert.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=x86_64-pc-windows-msvc -disable-strictnode-mutation %s -o - | FileCheck %s -check-prefix=WIN
+; RUN: llc -mtriple=x86_64-pc-linux -disable-strictnode-mutation %s -o -| FileCheck %s -check-prefix=UNIX
----------------
xiangzhangllvm wrote:
> pengfei wrote:
> > We don't use it anymore.
> Not use what ? the windows check is needed to meet the if condition ( line 4101 if (Node->isStrictFPOpcode()))
`-disable-strictnode-mutation`. X86 supports strict FP by default. This option is used for targets only support it partly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125159/new/

https://reviews.llvm.org/D125159



More information about the llvm-commits mailing list