[PATCH] D125159: [CodeGen] Fix ConvertNodeToLibcall for STRICT_FPOWI

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4106-4109
+        Results.push_back(
+            DAG.getNode(ISD::STRICT_FPOW, SDLoc(Node),
+                        {Node->getValueType(0), Node->getValueType(1)},
+                        {Exponent.getValue(1), Node->getOperand(1), Exponent}));
----------------
pengfei wrote:
> You still need to push the chain, like line 3870.
good catch!


================
Comment at: llvm/test/CodeGen/X86/float-strict-powi-convert.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=x86_64-pc-windows-msvc -disable-strictnode-mutation %s -o - | FileCheck %s -check-prefix=WIN
+; RUN: llc -mtriple=x86_64-pc-linux -disable-strictnode-mutation %s -o -| FileCheck %s -check-prefix=UNIX
----------------
pengfei wrote:
> We don't use it anymore.
Not use what ? the windows check is needed to meet the if condition ( line 4101 if (Node->isStrictFPOpcode()))


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125159/new/

https://reviews.llvm.org/D125159