[PATCH] D124118: [Peephole-Opt] For one kind of test-after-add pattern, eliminates test if it's correct to do so.

[Kan Shengchen via Phabricator via llvm-commits]

skan added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:1054
+    // in the `AND` and `TEST` operation; signed bit is not known for `AND`
+    // without peeking at #imm, and is known to be 0 as a result of
+    // `TEST64rr`.
----------------
skan wrote:
> Why don't we peek at imm here? It's possible to set `NoSignFlag` to `false`.
Never mind. I missed craig's comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124118/new/

https://reviews.llvm.org/D124118