[PATCH] D124942: [BOLT][TEST] Fix MCPlusBuilder::getAliases caching behavior

Wed May 4 10:43:33 PDT 2022

Amir added inline comments.

================
Comment at: bolt/lib/Core/MCPlusBuilder.cpp:446
   // alias (are sub or superregs of itself, including itself).
   static std::vector<BitVector> AliasMap;
   static std::vector<BitVector> SmallerAliasMap;
----------------
yota9 wrote:
> Thanks, strange that we didn't come across it before. But maybe it would be better to move these vectors to MCPlusBuilder object?
Yes, it’s really strange, but I've confirmed on a buildbot that it's really happening. Looks like we might randomly "get lucky" with aliases depending on register ids.

It's a good idea to move these vectors to MCPlusBuilder.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124942/new/

https://reviews.llvm.org/D124942