[PATCH] D123813: llvm-reduce: Clone some of the easy function properties

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 23:24:42 PDT 2022


dblaikie added a comment.

In D123813#3494994 <https://reviews.llvm.org/D123813#3494994>, @llvm-commits wrote:

> (as you already noticed this was approved).
>
> I bet this was manually marked because somehow our phabricator instance sometimes takes > 1 hour to recognize something as being committed and automatically add it. I also ended up manually adding a revision a couple of times thinking the automation was broken until I realized that it's just really slow.

Yeah, the main issue is that if a patch is approved without any comment, no email is sent to the list (so, if at all possible, please include some text when approving a patch to ensure the mailing list reflects the approved status) - and then I missed it when inspecting the review itself (to look for the "approved" status update in the review log UI at the top).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123813/new/

https://reviews.llvm.org/D123813



More information about the llvm-commits mailing list