[PATCH] D123813: llvm-reduce: Clone some of the easy function properties

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 13:54:51 PDT 2022


(as you already noticed this was approved).

I bet this was manually marked because somehow our phabricator instance sometimes takes > 1 hour to recognize something as being committed and automatically add it. I also ended up manually adding a revision a couple of times thinking the automation was broken until I realized that it's just really slow.

> On May 5, 2022, at 12:24 PM, David Blaikie via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> dblaikie added a comment.
> 
> In D123813#3460745 <https://reviews.llvm.org/D123813#3460745>, @arsenm wrote:
> 
>> 193fde7509d7805771adaef0f34186cb2cf6e084 <https://reviews.llvm.org/rG193fde7509d7805771adaef0f34186cb2cf6e084>
> 
> Generally, once something's sent for review, please don't commit it until it's been approved. (it creates a difficult incentive where we might end up normalizing committing code that needs review if there's a lack of code review feedback, which would be unfortunate)
> 
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D123813/new/
> 
> https://reviews.llvm.org/D123813
> 



More information about the llvm-commits mailing list