[PATCH] D124908: [SVE] Optimize new cases for lowerConvertToSVBool

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM with a naming nit, please leave others time to chime in before submitting as usual.



================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-reinterpret.ll:105-106
 
+; The reinterpret cast coming from the from.svbool intrinsic should prevent the
+; to.svbool from being simplified as a nop
+define <vscale x 16 x i1> @reinterpret_ptrue_reinterpret_cast() {
----------------
If I understand, as you say this test is not exercising REINTERPRET-of-REINTERPRET at the ISD level, can it be reworded to avoid 'reinterpret' and potentially being misleading?

It seems good to me to avoid reference to internal details here (which can be misleading or might change).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124908/new/

https://reviews.llvm.org/D124908