[PATCH] D124908: [SVE] Optimize new cases for lowerConvertToSVBool

Alban Bridonneau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 09:39:00 PDT 2022


alban.bridonneau updated this revision to Diff 427043.
alban.bridonneau added a comment.

I've changed the code to only explicitely check for splats of 1, rather
than all forms of all active predicates.
I also added the requested negative unit test. Note that this doesn't
actually guard the code that we just changed, because the to.bool is
lowered before the from.bool, so the from.bool has not yet been lowered
to reinterpret cast at this point. I kept the unit test anyway,
because this is a valid case to be tested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124908/new/

https://reviews.llvm.org/D124908

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/sve-intrinsics-reinterpret-no-streaming.ll
  llvm/test/CodeGen/AArch64/sve-intrinsics-reinterpret.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmpeq.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmpge.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmpgt.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmphi.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmphs.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmple.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmplo.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmpls.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmplt.ll
  llvm/test/CodeGen/AArch64/sve-ptest-removal-cmpne.ll
  llvm/test/CodeGen/AArch64/sve-vector-splat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124908.427043.patch
Type: text/x-patch
Size: 31972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220504/55b6efdd/attachment-0001.bin>


More information about the llvm-commits mailing list