[PATCH] D124951: [DAGCombiner] Fold (max/min X, X) -> X.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 23:56:23 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/min-max.ll:534
+; Tests with undef operands. These should fold to undef for RV32 or 0 for RV64.
+; FIXME: The RV64 cases are hitting pr55178.
 
----------------
We wouldn't hit the bug if we folded sext/zext undef in DAGCombiner. Instead we type legalize and hit the sext_inreg getNode bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124951/new/

https://reviews.llvm.org/D124951



More information about the llvm-commits mailing list