[PATCH] D124903: [X86][AMX] Replace PXOR instruction with SET0 in AMX pre config.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:401
         .addReg(Ymm);
+  } else if (ST.hasAVX()) {
+    ZeroSS(X86::VMOVUPSmr);
----------------
craig.topper wrote:
> LuoYuanke wrote:
> > @craig.topper , do you prefer to having AVX code path in a separate patch?
> The lambda feels like overkill.  keep has.SSE2 else block. And do 
> 
> unsigned StoreOpc = hasAVX() ? X86::VMOVUPSmr : MOVUPSmr. 
Ok, got you now. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124903/new/

https://reviews.llvm.org/D124903