[PATCH] D124903: [X86][AMX] Replace PXOR instruction with SET0 in AMX pre config.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 19:28:51 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:401
         .addReg(Ymm);
+  } else if (ST.hasAVX()) {
+    ZeroSS(X86::VMOVUPSmr);
----------------
LuoYuanke wrote:
> @craig.topper , do you prefer to having AVX code path in a separate patch?
The lambda feels like overkill.  keep has.SSE2 else block. And do 

unsigned StoreOpc = hasAVX() ? X86::VMOVUPSmr : MOVUPSmr. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124903/new/

https://reviews.llvm.org/D124903



More information about the llvm-commits mailing list