[PATCH] D124560: [llvm-objdump] Symbolize branch targets and basic block addresses based on the bb-address-map when present in the object file.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I've run out of time to properly review this today, but some more nits to be getting on with.



================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:689
+                           toString(TextSecOrErr.takeError()));
+      if (*TextSectionIndex != *TextSecOrErr - Sections.begin())
+        continue;
----------------
I'd find this more readable (i.e. I can tell more clearly that it is going to give you the right thing).


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:693-696
+    if (!BBAddrMapOrErr) {
+      return createError("unable to read " + describe(EF, Sec) + ": " +
+                         toString(BBAddrMapOrErr.takeError()));
+    }
----------------



================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-bbaddrmap-disassemble-symbolize-operands-multi-section.yaml:30
+# ATT-NEXT:   retq
+
+
----------------
Too many blank lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124560/new/

https://reviews.llvm.org/D124560