[PATCH] D124560: [llvm-objdump] Symbolize branch targets and basic block addresses based on the bb-address-map when present in the object file.

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:991
+    if (!ObjBBAddrMapOrErr) {
+      consumeError(ObjBBAddrMapOrErr.takeError());
+      return;
----------------
jhenderson wrote:
> It seems like this should at least be a warning?
Reporting errors now.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1332
 
+    std::unordered_map<uint64_t, BBAddrMap> AddrToBBAddrMap;
+    if (SymbolizeOperands)
----------------
jhenderson wrote:
> The Programmer's manual says not to use unordererd_map, although I doubt its reasoning is necessarily important here. Would `DenseMap` be more appropriate anyway?
Also changed the preexisting unordered_map to a DenseMap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124560/new/

https://reviews.llvm.org/D124560