[PATCH] D124608: [SimplifyCFG] Avoid shifting by a too large exponent.

Fri Apr 29 06:10:58 PDT 2022

fhahn added a comment.

In D124608#3482419 <https://reviews.llvm.org/D124608#3482419>, @spatel wrote:

> In D124608#3482047 <https://reviews.llvm.org/D124608#3482047>, @fhahn wrote:
>
>> In D124608#3480598 <https://reviews.llvm.org/D124608#3480598>, @spatel wrote:
>>
>>> Are the tests changing with this patch? Use `--check-globals` with update_test_checks.py to verify that the table entries are as expected?
>>
>> Thanks, I updated the test with `--check-globals`. It looks like the update script doesn't use the pattern for the global at its uses, I'll file a bug for that.
>>
>> There are no test changes. I think for test changes we would need a table with a size larger than fits into a 64 bit integer.
>
> I see. So was this bug found only by inspection?

It was found when using a Clang build with UBSan :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124608/new/

https://reviews.llvm.org/D124608