[PATCH] D124608: [SimplifyCFG] Avoid shifting by a too large exponent.

Fri Apr 29 06:08:06 PDT 2022

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

In D124608#3482047 <https://reviews.llvm.org/D124608#3482047>, @fhahn wrote:

> In D124608#3480598 <https://reviews.llvm.org/D124608#3480598>, @spatel wrote:
>
>> Are the tests changing with this patch? Use `--check-globals` with update_test_checks.py to verify that the table entries are as expected?
>
> Thanks, I updated the test with `--check-globals`. It looks like the update script doesn't use the pattern for the global at its uses, I'll file a bug for that.
>
> There are no test changes. I think for test changes we would need a table with a size larger than fits into a 64 bit integer.

I see. So was this bug found only by inspection?
It's hard to keep track of the various size constraints in this code, but this seems ok. LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124608/new/

https://reviews.llvm.org/D124608