[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Aaron Puchert via Phabricator via llvm-commits]

aaronpuchert added a comment.

In D124153#3480334 <https://reviews.llvm.org/D124153#3480334>, @kippesp wrote:

> If CMAKE_BUILD_TYPE is specified in a multi-configuration build (like visual studio), the alternative build types won't be available.

I'm not on Windows, but the CMake documentation <https://cmake.org/cmake/help/latest/manual/cmake-buildsystem.7.html#build-configurations> says:

> For multi-configuration generators like Visual Studio, Xcode, and Ninja Multi-Config, the configuration is chosen by the user at build time and `CMAKE_BUILD_TYPE` is ignored.

But it's pointless to require something that will be ignored, so I agree that it makes sense to have the requirement dependent on GENERATOR_IS_MULTI_CONFIG <https://cmake.org/cmake/help/latest/prop_gbl/GENERATOR_IS_MULTI_CONFIG.html>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153