[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Paul Kippes via Phabricator via llvm-commits]

kippesp added a comment.

In D124153#3470932 <https://reviews.llvm.org/D124153#3470932>, @jhenderson wrote:

> That being said, I am a Windows developer who almost exclusively builds Visual Studio projects these days, so I have the luxury of being able to click a drop-down menu and change the config that way.

If CMAKE_BUILD_TYPE is specified in a multi-configuration build (like visual studio), the alternative build types won't be available.  Usually when using MSBUILD, CMAKE_BUILD_TYPE should go unspecified at configuration time and the build type given at build time.  Multi-configuration build types should probably omit this requirement.

cmake path/to/llvm
cmake --build . --config Debug
cmake --build . --config Release
etc


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153