[PATCH] D39758: CodeGen: Fix pointer info in SplitVecOp_EXTRACT_VECTOR_ELT

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 01:08:17 PDT 2022


foad added inline comments.


================
Comment at: llvm/trunk/include/llvm/CodeGen/MachineMemOperand.h:41-42
   /// This is the IR pointer value for the access, or it is null if unknown.
   /// If this is null, then the access is to a pointer in the default address
   /// space.
   PointerUnion<const Value *, const PseudoSourceValue *> V;
----------------
arsenm wrote:
> foad wrote:
> > Am I right in thinking that this part of the comment should have been removed, since we're now allowing a null pointer here but with a specified (non-default) address space?
> Yes
I removed it: 515f890033ccaad3890333513731e4c5b6db2482


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D39758/new/

https://reviews.llvm.org/D39758



More information about the llvm-commits mailing list