[PATCH] D124473: [NVPTX] Fix NVPTX DebugInfo tests on Windows

Andrew Savonichev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 02:30:14 PDT 2022


asavonic updated this revision to Diff 425446.
asavonic retitled this revision from "[NVPTX] Fix dwarf-file-dir.ll on Windows" to "[NVPTX] Fix NVPTX DebugInfo tests on Windows".
asavonic edited the summary of this revision.
asavonic added a reviewer: thakis.
asavonic added a subscriber: thakis.
asavonic added a comment.

I missed two other tests that failed because of the same issue: debug-file-loc.ll and debug-file-loc-only.ll.
@thakis tried to fix them in a1bb5719eca6 <https://reviews.llvm.org/rGa1bb5719eca6a0e5b142518de6e25f45858baf1a> (thanks a lot!), but I'm not sure if it helped - we need two backslash characters in the regex.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124473/new/

https://reviews.llvm.org/D124473

Files:
  llvm/test/DebugInfo/NVPTX/debug-file-loc-only.ll
  llvm/test/DebugInfo/NVPTX/debug-file-loc.ll
  llvm/test/DebugInfo/NVPTX/dwarf-file-dir.ll


Index: llvm/test/DebugInfo/NVPTX/dwarf-file-dir.ll
===================================================================
--- llvm/test/DebugInfo/NVPTX/dwarf-file-dir.ll
+++ llvm/test/DebugInfo/NVPTX/dwarf-file-dir.ll
@@ -1,10 +1,7 @@
 ; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda | FileCheck --check-prefix=CHECK-NODIR %s
 ; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda -dwarf-directory=1 | FileCheck --check-prefix=CHECK-DIR %s
 
-; compilation on Windows results in: /tmp/dbginfo/a\\a.cpp
-; UNSUPPORTED: windows
-
-; CHECK-NODIR: .file   {{[0-9]+}} "/tmp/dbginfo/a/a.cpp"
+; CHECK-NODIR: .file   {{[0-9]+}} "/tmp/dbginfo/a{{/|\\\\}}a.cpp"
 ;
 ; ptxas does not support .file directory syntax, but it can still be
 ; forced by -dwarf-directory=1
Index: llvm/test/DebugInfo/NVPTX/debug-file-loc.ll
===================================================================
--- llvm/test/DebugInfo/NVPTX/debug-file-loc.ll
+++ llvm/test/DebugInfo/NVPTX/debug-file-loc.ll
@@ -27,8 +27,8 @@
   ret void, !dbg !11
 }
 
-; CHECK-DAG: .file [[FOO]] "/source/dir{{[/\\]}}foo.h"
-; CHECK-DAG: .file [[BAR]] "/source/dir{{[/\\]}}bar.cu"
+; CHECK-DAG: .file [[FOO]] "/source/dir{{/\\\\}}foo.h"
+; CHECK-DAG: .file [[BAR]] "/source/dir{{/\\\\}}bar.cu"
 ; CHECK: .section .debug_abbrev
 ; CHECK-NEXT: {
 ; CHECK-NEXT: .b8 1                                // Abbreviation Code
Index: llvm/test/DebugInfo/NVPTX/debug-file-loc-only.ll
===================================================================
--- llvm/test/DebugInfo/NVPTX/debug-file-loc-only.ll
+++ llvm/test/DebugInfo/NVPTX/debug-file-loc-only.ll
@@ -27,8 +27,8 @@
   ret void, !dbg !11
 }
 
-; CHECK-DAG: .file [[FOO]] "/source/dir{{[/\\]}}foo.h"
-; CHECK-DAG: .file [[BAR]] "/source/dir{{[/\\]}}bar.cu"
+; CHECK-DAG: .file [[FOO]] "/source/dir{{/|\\\\}}foo.h"
+; CHECK-DAG: .file [[BAR]] "/source/dir{{/|\\\\}}bar.cu"
 
 ; CHECK-NOT: .section .debug{{.*}}
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124473.425446.patch
Type: text/x-patch
Size: 1895 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220427/cf301df8/attachment.bin>


More information about the llvm-commits mailing list