[PATCH] D123964: CodeGen: Replace some uses of LLVMTargetMachine with TargetMachine

[Eric Christopher via llvm-commits]

On Tue, Apr 26, 2022 at 8:17 PM Matthias Braun via Phabricator <
reviews at reviews.llvm.org> wrote:

> MatzeB added inline comments.
>
>
> ================
> Comment at: llvm/include/llvm/Target/TargetMachine.h:137
> +  /// registers, except that variadic defs will be allocated vregs.
> +  virtual bool usesPhysRegsForValues() const { return true; }
> +
> ----------------
> arsenm wrote:
> > echristo wrote:
> > > I'm curious what this changes here versus using LLVMTargetMachine.
> It's been a while since I've looked.
> > It doesn't really change anything, but this one doesn't fit the theme of
> the what LLVMTargetMachine adds. This is core target information and it
> doesn't make much since to have it in LLVMTargetMachine, which only adds
> pass machinery controls.
> This seems like an implementation detail of `lib/CodeGen` so I think it
> should stay withint `LLVMTargetMachine`.
>

Thanks for the memory as well. I agree with everything here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220427/15d7aee1/attachment.html>