[PATCH] D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 08:42:11 PDT 2022


spatel added a comment.

In D124369#3477338 <https://reviews.llvm.org/D124369#3477338>, @nico-abram wrote:

> Updated the patch with `update_test_checks.py` run with the changes applied on top of https://reviews.llvm.org/rGfd9026131e6c5de6f4e582d5c85c5b5588672dfb
> Looks like what I'd expect. It's optimizing it through the opaque use call, but that doesn't look like a problem to me.
>
> I also removed the `setHasNoSignedWrap(false)` and it did not change the test results or the upodate_test_checks changes. Not sure what I was seeing yesterday.

Please rebase this patch on latest main - that way we'll just see the diffs in the tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124369/new/

https://reviews.llvm.org/D124369



More information about the llvm-commits mailing list