[PATCH] D124369: [InstCombine] C0 >>{ashr, exact} (X - C1) --> (C0 << C1) >>{ashr} X

Nicolas Abram via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 08:04:31 PDT 2022


nico-abram updated this revision to Diff 425522.
nico-abram added a comment.

Updated the patch with `update_test_checks.py` run with the changes applied on top of https://reviews.llvm.org/rGfd9026131e6c5de6f4e582d5c85c5b5588672dfb
Looks like what I'd expect. It's optimizing it through the opaque use call, but that doesn't look like a problem to me.

I also removed the `setHasNoSignedWrap(false)` and it did not change the test results or the upodate_test_checks changes. Not sure what I was seeing yesterday.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124369/new/

https://reviews.llvm.org/D124369

Files:
  llvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
  llvm/test/Transforms/InstCombine/shift-add.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124369.425522.patch
Type: text/x-patch
Size: 10716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220427/45ad88f2/attachment.bin>


More information about the llvm-commits mailing list