[PATCH] D123953: llvm-reduce: Add cloning of target MachineFunctionInfo

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 06:43:38 PDT 2022


arsenm added a comment.

In D123953#3476385 <https://reviews.llvm.org/D123953#3476385>, @MatzeB wrote:

> I wonder if we wouldn't be better off by just adding an implementation into the baseclass that does `return nullptr;` and then abort the llvm-reduce process? That way implementing a proper `clone()` function becomes a problem for the individual target maintainers when they want to use `llvm-reduce` and we should get more complete/correct implementations.

That is what this does, it just turned out to be not very difficult to implement for every target once frame index values are stable


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123953/new/

https://reviews.llvm.org/D123953



More information about the llvm-commits mailing list