[PATCH] D123953: llvm-reduce: Add cloning of target MachineFunctionInfo
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 26 21:18:10 PDT 2022
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
I wonder if we wouldn't be better off by just adding an implementation into the baseclass that does `return nullptr;` and then abort the llvm-reduce process? That way implementing a proper `clone()` function becomes a problem for the individual target maintainers when they want to use `llvm-reduce` and we should get more complete/correct implementations.
That said I don't care too deeply either way. So LGTM leaving the `return nullptr` change to your discretion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123953/new/
https://reviews.llvm.org/D123953
More information about the llvm-commits
mailing list