[PATCH] D124485: [AMDGPU] Remove vdata from buffer to lds load

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 26 17:05:11 PDT 2022


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:497
   : MUBUF_Pseudo<opName,
-                 (outs vdata_op:$vdata),
+                 !if(isLds, (outs ), (outs vdata_op:$vdata)),
                  !con(getMUBUFIns<addrKindCopy, [], isLds>.ret,
----------------
rampitec wrote:
> arsenm wrote:
> > Extra space after outs
> Did we finally fixed the issue when this extra space was needed?
Not sure


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124485/new/

https://reviews.llvm.org/D124485



More information about the llvm-commits mailing list