[PATCH] D124485: [AMDGPU] Remove vdata from buffer to lds load

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D124485#3475887 <https://reviews.llvm.org/D124485#3475887>, @arsenm wrote:

> Did these instructions just not actually have vdata?

Yes, they don't. These are DMA. They read vmem and write LDS without touching any VGPRs. That's the whole point for these to exist.

buffer_store_lds does not have it, any of flat DMA instructions don't. This is just the old bug.



================
Comment at: llvm/lib/Target/AMDGPU/BUFInstructions.td:497
   : MUBUF_Pseudo<opName,
-                 (outs vdata_op:$vdata),
+                 !if(isLds, (outs ), (outs vdata_op:$vdata)),
                  !con(getMUBUFIns<addrKindCopy, [], isLds>.ret,
----------------
arsenm wrote:
> Extra space after outs
Did we finally fixed the issue when this extra space was needed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124485/new/

https://reviews.llvm.org/D124485