[PATCH] D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC.

Tue Apr 26 06:36:26 PDT 2022

jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks.

================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:299
+  /// Check if Opcode corresponds to a call instruction that should be marked
+  /// with the NOTOC relocation.
+  bool isNoTOCCallInstr(unsigned Opcode) const {
----------------
shchenz wrote:
> I am in favor of Jinsong's comment in https://reviews.llvm.org/D122012#3392673. Could we use a flag in the td file (with a default true/false value) instead of listing all call instructions in the cpp file?
Thanks Zheng, we had some offline discussion, and I agreed that this can be a tradeoff between cost and benefits.
So I am OK with this. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124415/new/

https://reviews.llvm.org/D124415