[PATCH] D124415: [PowerPC][NFC] Add a function to determine if a call needs to be NOTOC.

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 22:42:19 PDT 2022


shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.h:299
+  /// Check if Opcode corresponds to a call instruction that should be marked
+  /// with the NOTOC relocation.
+  bool isNoTOCCallInstr(unsigned Opcode) const {
----------------
I am in favor of Jinsong's comment in https://reviews.llvm.org/D122012#3392673. Could we use a flag in the td file (with a default true/false value) instead of listing all call instructions in the cpp file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124415/new/

https://reviews.llvm.org/D124415



More information about the llvm-commits mailing list