[PATCH] D123054: InstructionCombining: merge realloc and free handling

[Augie Fackler via Phabricator via llvm-commits]

durin42 abandoned this revision.
durin42 added a comment.

In D123054#3472752 <https://reviews.llvm.org/D123054#3472752>, @nikic wrote:

> I don't think this change is semantically right. For example, the function could now also be an allocator function that just happens to accept a pointer argument -- say, an allocator that allocates into a memory region. I think we do need to explicitly check that it's a free/realloc.
>
> What's the motivation for this change?

Oh, great point. This was an unconsidered leftover from a previous incarnation of this (before allockind() existed) and it can be replaced by D124425 <https://reviews.llvm.org/D124425> (which comes later in the sequence). I'll mark this as abandoned. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123054/new/

https://reviews.llvm.org/D123054