[PATCH] D123054: InstructionCombining: merge realloc and free handling

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 12:57:17 PDT 2022


nikic added a reviewer: nikic.
nikic added a comment.

I don't think this change is semantically right. For example, the function could now also be an allocator function that just happens to accept a pointer argument -- say, an allocator that allocates into a memory region. I think we do need to explicitly check that it's a free/realloc.

What's the motivation for this change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123054/new/

https://reviews.llvm.org/D123054



More information about the llvm-commits mailing list