[PATCH] D124383: llvm-reduce: Do not try to delete frame instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 13:41:44 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/mir/remove-frame-destroy.mir:5
+
+# CHECK-INTERESTINGNESS: S_NOP 0
+
----------------
markus wrote:
> Is this criteria for interestingness safe given that we have two `S_NOP 0` instructions in the block? Could it be that the first one gets eliminated and then it is still considered interesting but the final RESULT-NEXT fails because there is now a `S_NOP 0` in the middle?
With this condition both nops should be deleted (the first one won't be deleted until the other patch for first instruction handling)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124383/new/

https://reviews.llvm.org/D124383



More information about the llvm-commits mailing list