[PATCH] D124383: llvm-reduce: Do not try to delete frame instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 25 13:40:25 PDT 2022


arsenm added a comment.

In D124383#3471743 <https://reviews.llvm.org/D124383#3471743>, @markus wrote:

> I recall running into this as well. So this patch will make sure that they are never deleted thus improving reduction speed. But wasn't there a chance that the oracle would indicated that both instructions of the pair were to be deleted which could result in a valid reduction? I guess this is fine though and a better solution would be to deal with the frame pairs in a separate reduction pass anyway.

I was thinking a frame reduction pass would be better


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124383/new/

https://reviews.llvm.org/D124383



More information about the llvm-commits mailing list