[PATCH] D123951: [LLVM][AIX] Implement XCOFF exported visibility

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 22 10:40:59 PDT 2022


daltenty updated this revision to Diff 424528.
daltenty added a comment.

Update the patch based on feedback on the RFC (https://discourse.llvm.org/t/rfc-adding-exported-visibility-style-to-the-ir-to-model-xcoff-exported-visibility/61853/8). There seem to be limited visibility bits, and the implementation has kind of reserved space for `internal`, so adding `exported` may cause problems. On the other hand `dllexport` appears to match the semantic and currently only be used as a marker to indicate to some passes that we should preserve the symbol since it will be exported from shared objects (which is exactly what we want too), so I've updated the implementation as suggested to use `dllexport` instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123951/new/

https://reviews.llvm.org/D123951

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/MC/MCAsmInfo.h
  llvm/include/llvm/MC/MCDirectives.h
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCMachOStreamer.cpp
  llvm/lib/MC/MCXCOFFStreamer.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/test/CodeGen/PowerPC/aix-xcoff-visibility.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123951.424528.patch
Type: text/x-patch
Size: 8599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220422/90001adf/attachment.bin>


More information about the llvm-commits mailing list