[PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/test/Fir/embox.fir:1
-// RUN: fir-opt %s | tco | FileCheck %s
+// RUN: fir-opt %s | tco -disable-external-name-interop | FileCheck %s
 
----------------
I don't understand why running a `fir-opt` nullary execution is needed.


================
Comment at: flang/test/Lower/common-block.f90:1
-! RUN: bbc %s -o - | tco | FileCheck %s
+! RUN: bbc %s -o - | tco -disable-external-name-interop | FileCheck %s
 
----------------
rovka wrote:
> schweitz wrote:
> > This pass will have to be disabled in `tco` by default for tests to pass.
> Why? I thought the main purpose of a flag to disable the pass was to facilitate testing.
> I'm working from the premise that we want to keep flang-new and tco compatible, which means that if we enable the pass by default in flang-new, we should enable it by default in tco as well.
That's not the right premise. `tco` doesn't need to be in lock-step with the official compiler because it is intended to solve separable problems. I don't want artificial barriers and specious objectives introduced into the test tool. The fact they can be used independently and may produce differing output is actually a good thing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171