[PATCH] D114841: [lld-macho] Fix duplicate symbols with relocatable objects

[Keith Smiley via Phabricator via llvm-commits]

keith added inline comments.


================
Comment at: lld/MachO/Driver.cpp:410
       }
+    } else if (isa<ObjFile>(file) || isa<BitcodeFile>(file)) {
+      // Cache frameworks containing object or bitcode files to avoid duplicate
----------------
thakis wrote:
> `file` can be null here (e.g. if loading an invalid tbd file), which now makes lld crash with
> 
> ```
> Assertion failed: (Val && "isa<> used on a null pointer"), function doit, file Casting.h, line 104.
> ```
> 
> Could you fix this?
Thanks! https://reviews.llvm.org/D124271


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114841/new/

https://reviews.llvm.org/D114841