[PATCH] D114841: [lld-macho] Fix duplicate symbols with relocatable objects

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.
Herald added a project: All.


================
Comment at: lld/MachO/Driver.cpp:410
       }
+    } else if (isa<ObjFile>(file) || isa<BitcodeFile>(file)) {
+      // Cache frameworks containing object or bitcode files to avoid duplicate
----------------
`file` can be null here (e.g. if loading an invalid tbd file), which now makes lld crash with

```
Assertion failed: (Val && "isa<> used on a null pointer"), function doit, file Casting.h, line 104.
```

Could you fix this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114841/new/

https://reviews.llvm.org/D114841