[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Aaron Puchert via Phabricator via llvm-commits]

aaronpuchert added a comment.

In D124153#3466525 <https://reviews.llvm.org/D124153#3466525>, @tstellar wrote:

> My experience tells me that if we present 3 options to choose from, many users will just randomly pick one without thinking about it, and we'll still get bug reports about debug builds using too much memory.

But @mehdi_amini's suggestion was to print `-DCMAKE_BUILD_TYPE=Debug  # Unoptimized, with debug info (large binaries)`, so they made a choice and knew what it would entail.

> To me it makes the most sense to just default to Release builds with no asserts, this is the easiest to implement and it will give new users the best experience in my opinion.

Nobody has any doubts that Release builds provide the best experience for //users//, but wouldn't most users simply take prebuilt binaries instead of cloning a 1G repository and running a build that can take a good hour or even more, depending on how much you want to build? Maybe most people building their own LLVM want to investigate a bug or develop a new feature?

Chances are that changing the defaults will just make a different set of people mad, disappointed that they had to rebuild with debug info or that they don't see assertions by default.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153