[PATCH] D124153: [CMake] Change default CMAKE_BUILD_TYPE to Release

[Tobias Hieta via Phabricator via llvm-commits]

thieta added a comment.

In D124153#3467394 <https://reviews.llvm.org/D124153#3467394>, @aaron.ballman wrote:

> I think both of the situations are basically the same with basically the same outcomes -- if the user picks the "correct" build target (either through the default or explicitly), they're happy, if not, they're unhappy.

That's a fair point.

I actually think that erroring out if you don't specify a `CMAKE_BUILD_TYPE` is not a bad alternative. If we write a good error message describing the different options in user-friendly terms I think it might be the option that's the least confusing for new users.

The only real downside to it I can see right now is that I haven't seen many other projects behave in this way - so it would set LLVM apart, but on the other hand - as you point out: LLVM is big and building the "wrong" configuration has bigger ramification than for example "zlib".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153