[PATCH] D124224: [AArch64][SVE] Add some logical operation DestructiveBinaryComm patterns

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

This patch seems sensible to me! I just had a couple of minor comments.



================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:2773
+                                DestructiveInstTypeEnum flags,
+                                string revname="", bit isOrig=0> {
+  let DestructiveInstType = flags in {
----------------
I don't think we need these because there aren't any reverse logical operations.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:2776
+  def _B : sve_int_bin_pred_arit_log<0b00, 0b11, opc, asm, ZPR8>,
+             SVEPseudo2Instr<Ps # _B, 1>, SVEInstr2Rev<NAME # _B, revname # _B, isOrig>;
+  def _H : sve_int_bin_pred_arit_log<0b01, 0b11, opc, asm, ZPR16>,
----------------
Again, I don't think we need any of these for the logical operations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124224/new/

https://reviews.llvm.org/D124224