[PATCH] D124106: [lld/mac] Warn that writing zippered outputs isn't implemented

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 21 08:06:00 PDT 2022


oontvoo added inline comments.


================
Comment at: lld/MachO/Driver.cpp:649-650
+    // write zippered executables.
+    warn("writing zippered outputs not yet implemented, "
+         "ignoring all but last -platform_version flag");
+  }
----------------
Should we verify that this is indeed because of the zippered dylib expansion of arguments?
(This is now assuming that whenever two or more platform_version arguments are passed, it is because of the zippered dylib, but that might not always be the case, eg. users accidentally pass the args multiple times)
Warning "writing zippered outputs..." here would be a bit confusing.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124106/new/

https://reviews.llvm.org/D124106



More information about the llvm-commits mailing list